]> Cypherpunks repositories - gostls13.git/commit
net/http: clarify when it is safe to reuse a request
authorTom Bergan <tombergan@google.com>
Thu, 2 Nov 2017 22:41:10 +0000 (15:41 -0700)
committerTom Bergan <tombergan@google.com>
Thu, 2 Nov 2017 23:51:25 +0000 (23:51 +0000)
commit3039bff9d07ce05dc9af8c155c6929ae5e53a231
tree1b8e146fe47e76653447ba47826ceaa67fcf330d
parentaf37332d160e096fe5bedc551f318c7b76d4e57a
net/http: clarify when it is safe to reuse a request

The godoc for RoundTrip already specifies when it's ok to reuse a
request that contains a body: the caller must wait until RoundTrip
calls Close on Request.Body.

This CL adds a small clarification: If the request does not have a
body, it can be reused as long as the caller does not mutate the
Request until RoundTrip fails or the Response.Body is closed.

Fixes #19653

Change-Id: I56652a9369978d11650e2e6314104831c2ce5e78
Reviewed-on: https://go-review.googlesource.com/75671
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/client.go