]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix typechecking in finishcompare
authorKunpei Sakai <namusyaka@gmail.com>
Sun, 25 Feb 2018 09:14:20 +0000 (18:14 +0900)
committerMatthew Dempsky <mdempsky@google.com>
Mon, 26 Feb 2018 22:10:51 +0000 (22:10 +0000)
commit30673769ed7409da0ba1046e874371bf4f07d352
treee4b601067ea744b1fdd7d84802f25fe469412f98
parent0c471dfae29b0759c6f12e32d2d5ca69ea79d5d8
cmd/compile: fix typechecking in finishcompare

Previously, finishcompare just used SetTypecheck, but this didn't
recursively update any untyped bool typed subexpressions. This CL
changes it to call typecheck, which correctly handles this.

Also cleaned up outdated code for simplifying logic.

Updates #23834

Change-Id: Ic7f92d2a77c2eb74024ee97815205371761c1c90
Reviewed-on: https://go-review.googlesource.com/97035
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/walk.go