]> Cypherpunks repositories - gostls13.git/commit
crypto/internal/fips/sha3: restructure as an internal package
authorFilippo Valsorda <filippo@golang.org>
Wed, 2 Oct 2024 09:37:38 +0000 (11:37 +0200)
committerGopher Robot <gobot@golang.org>
Mon, 28 Oct 2024 14:52:21 +0000 (14:52 +0000)
commit312e7e9f8a85bbab449daae6ebe969ad1d4f0840
treeb54370a29e8d3ef989ee0d561fe80b0bae13eb74
parent7557a24927080557fc9baec62786e8c1d1aaa4b5
crypto/internal/fips/sha3: restructure as an internal package

Main changes are

    - return concrete *Digest and *SHAKE instead of interfaces

    - make tests external (sha3_test) so they will be easy to move to
      the public package

    - drop most of the developer guidance docs (to be updated and
      reintroduced in the public package)

    - consolidate the _noasm.go files (matching the single _s390x.go)

    - move TestAllocations from build tags to testenv

    - temporarily disable s390x code, to refactor in a following CL

For #69536

Change-Id: Ie5fd3e2b589b9eb835b9e3174b7a79c2ac728ab1
Reviewed-on: https://go-review.googlesource.com/c/go/+/617357
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
12 files changed:
src/crypto/internal/fips/hmac/hmac.go
src/crypto/internal/fips/sha3/allocations_test.go [deleted file]
src/crypto/internal/fips/sha3/doc.go [deleted file]
src/crypto/internal/fips/sha3/hashes.go
src/crypto/internal/fips/sha3/hashes_noasm.go [deleted file]
src/crypto/internal/fips/sha3/sha3.go
src/crypto/internal/fips/sha3/sha3_noasm.go [new file with mode: 0644]
src/crypto/internal/fips/sha3/sha3_s390x.go
src/crypto/internal/fips/sha3/sha3_s390x.s
src/crypto/internal/fips/sha3/sha3_test.go
src/crypto/internal/fips/sha3/shake.go
src/crypto/internal/fips/sha3/shake_noasm.go [deleted file]