]> Cypherpunks repositories - gostls13.git/commit
testing: use function names to identify helpers
authorDavid Lazar <lazard@golang.org>
Thu, 20 Apr 2017 20:19:55 +0000 (16:19 -0400)
committerDavid Lazar <lazard@golang.org>
Fri, 21 Apr 2017 15:34:32 +0000 (15:34 +0000)
commit318812e7c1b6b9ca890e62263a4cab1cb78ea6ed
treea5935b81ba546b404728bc2af5e57890f4d53573
parent2397cd0fbfd5ede1a52575f5e6dfa4456e967cc4
testing: use function names to identify helpers

Previously, helpers were identified by entry PC, but this breaks if the
helper is inlined (as in notHelperCallingHelper). Instead, identify
helpers by function name (with package path). Now TestTBHelper and
TestTBHelperParallel pass with -l=4.

To keep the code unified, this change makes it so that the runner
is also identified by function name instead of entry PC.

Change-Id: I1b1987fc49d114e69d075fab56aeeacd5294982b
Reviewed-on: https://go-review.googlesource.com/41257
Run-TryBot: David Lazar <lazard@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Austin Clements <austin@google.com>
src/testing/testing.go