]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix incoming ABI with GOEXPERIMENT=regabiargs
authorAustin Clements <austin@google.com>
Wed, 31 Mar 2021 20:40:52 +0000 (16:40 -0400)
committerAustin Clements <austin@google.com>
Thu, 1 Apr 2021 00:51:23 +0000 (00:51 +0000)
commit3304b2235af0a88ba0bb21edaf2c60df47b6e0a8
tree11e2393b31bc6a4df92afa01ba7037b6c530fd43
parent87c6fa4f473f178f7d931ddadd10c76444f8dc7b
cmd/compile: fix incoming ABI with GOEXPERIMENT=regabiargs

When regabiargs is enabled, a function's incoming ABI should be
determined solely by the function's own definition ABI (which is
usually ABIInternal, but can be ABI0 for ABI wrappers).

For example, the current code miscompiles ABI0 -> ABIInternal wrappers
when the experiment is enabled because it treats the wrapper itself as
being called as ABIInternal. This causes it to assume the incoming
arguments are already in registers, so usually the wrapper doesn't do
anything with the arguments because it thinks they're already in the
right place. With this fix, these wrappers now correctly load the
arguments from the stack and put them in registers.

For #40724.

Change-Id: Iec784e88ebc55d9e95e830ed7533aa336f3b1ca2
Reviewed-on: https://go-review.googlesource.com/c/go/+/306409
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/ssagen/ssa.go