]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] cmd/compile: fix conditional select rule
authorKeith Randall <khr@golang.org>
Fri, 9 Dec 2022 18:55:28 +0000 (10:55 -0800)
committerDavid Chase <drchase@google.com>
Mon, 19 Dec 2022 21:46:43 +0000 (21:46 +0000)
commit337138c10c7aff6b4bdcb5472128a3ba11d57620
treed2ccdf247607b79b0f544a2c488841f3ffe9f6c7
parentd17cf5654105ff4f9490870586175990de3334a7
[release-branch.go1.18] cmd/compile: fix conditional select rule

ARM64 maintains booleans in the low byte of registers. Upper parts
of that register are junk.
This rule is using all 32 bits of a boolean-containing register, which
is wrong. Change the rule to only look at the low bit.

Fixes #57211

Change-Id: Ibbef86b2be859df3d06d993db00e1231c481c428
Reviewed-on: https://go-review.googlesource.com/c/go/+/456556
Auto-Submit: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/456558
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/compile/internal/ssa/gen/ARM64.rules
src/cmd/compile/internal/ssa/rewriteARM64.go
test/fixedbugs/issue57184.go [new file with mode: 0644]