]> Cypherpunks repositories - gostls13.git/commit
cmd/go: declare net hosts in script tests
authorBryan C. Mills <bcmills@google.com>
Fri, 3 Mar 2023 14:48:10 +0000 (14:48 +0000)
committerBryan Mills <bcmills@google.com>
Mon, 24 Apr 2023 15:54:04 +0000 (15:54 +0000)
commit33c06ee12a53e293f4a787c1dfde7eb7ddb0be63
tree22ef74e2df2a60a2cafc50a06a04ed43e0ac3604
parentc2c787d73e6fadd57ebcc9fb07532332637b9164
cmd/go: declare net hosts in script tests

Although we aren't precise about enforcing the hosts just yet,
we can eventually use the declared hostnames to selectively skip
tests (for example, if an external service has an outage while
a Go release is being tested).

Also relax the constraint to [short] in tests that require only
vcs-test.golang.org, which has redirected to an in-process server
since around CL 427914.

Also enforce that tests that use the network actually use the [net]
constraint, by setting TESTGONETWORK=panic in the test environment
until the condition is evaluated.

For #52545.
For #54503.
Updates #27494.

Change-Id: I13be6b42a9beee97657eb45424882e787ac164c3
Reviewed-on: https://go-review.googlesource.com/c/go/+/473276
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Bypass: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
73 files changed:
src/cmd/go/internal/web/http.go
src/cmd/go/script_test.go
src/cmd/go/scriptconds_test.go
src/cmd/go/testdata/script/README
src/cmd/go/testdata/script/get_404_meta.txt
src/cmd/go/testdata/script/get_custom_domain_wildcard.txt
src/cmd/go/testdata/script/get_dash_t.txt
src/cmd/go/testdata/script/get_domain_root.txt
src/cmd/go/testdata/script/get_dot_slash_download.txt
src/cmd/go/testdata/script/get_goroot.txt
src/cmd/go/testdata/script/get_insecure.txt
src/cmd/go/testdata/script/get_insecure_custom_domain.txt
src/cmd/go/testdata/script/get_insecure_env.txt
src/cmd/go/testdata/script/get_insecure_redirect.txt
src/cmd/go/testdata/script/get_insecure_update.txt
src/cmd/go/testdata/script/get_internal_wildcard.txt
src/cmd/go/testdata/script/get_issue11307.txt
src/cmd/go/testdata/script/get_issue16471.txt
src/cmd/go/testdata/script/get_issue22125.txt
src/cmd/go/testdata/script/get_non_pkg.txt
src/cmd/go/testdata/script/get_race.txt
src/cmd/go/testdata/script/get_test_only.txt
src/cmd/go/testdata/script/get_tilde.txt
src/cmd/go/testdata/script/get_update.txt
src/cmd/go/testdata/script/get_update_all.txt
src/cmd/go/testdata/script/get_update_unknown_protocol.txt
src/cmd/go/testdata/script/get_update_wildcard.txt
src/cmd/go/testdata/script/get_vendor.txt
src/cmd/go/testdata/script/get_with_git_trace.txt
src/cmd/go/testdata/script/gopath_moved_repo.txt
src/cmd/go/testdata/script/gopath_vendor_dup_err.txt
src/cmd/go/testdata/script/govcs.txt
src/cmd/go/testdata/script/install_shadow_gopath.txt
src/cmd/go/testdata/script/list_std_vendor.txt
src/cmd/go/testdata/script/mod_auth.txt
src/cmd/go/testdata/script/mod_convert.txt
src/cmd/go/testdata/script/mod_convert_tsv_insecure.txt
src/cmd/go/testdata/script/mod_download_git_decorate_full.txt
src/cmd/go/testdata/script/mod_download_hash.txt
src/cmd/go/testdata/script/mod_download_insecure_redirect.txt
src/cmd/go/testdata/script/mod_download_issue51114.txt
src/cmd/go/testdata/script/mod_download_private_vcs.txt
src/cmd/go/testdata/script/mod_download_svn.txt
src/cmd/go/testdata/script/mod_get_direct.txt
src/cmd/go/testdata/script/mod_get_fallback.txt
src/cmd/go/testdata/script/mod_get_fossil.txt
src/cmd/go/testdata/script/mod_get_hash.txt
src/cmd/go/testdata/script/mod_get_major.txt
src/cmd/go/testdata/script/mod_get_pseudo.txt
src/cmd/go/testdata/script/mod_get_pseudo_other_branch.txt
src/cmd/go/testdata/script/mod_get_pseudo_prefix.txt
src/cmd/go/testdata/script/mod_getx.txt
src/cmd/go/testdata/script/mod_git_export_subst.txt
src/cmd/go/testdata/script/mod_gonoproxy.txt
src/cmd/go/testdata/script/mod_gopkg_unstable.txt
src/cmd/go/testdata/script/mod_init_glide.txt
src/cmd/go/testdata/script/mod_invalid_version.txt
src/cmd/go/testdata/script/mod_list_direct.txt
src/cmd/go/testdata/script/mod_list_odd_tags.txt
src/cmd/go/testdata/script/mod_missing_repo.txt
src/cmd/go/testdata/script/mod_prefer_compatible.txt
src/cmd/go/testdata/script/mod_proxy_errors.txt
src/cmd/go/testdata/script/mod_proxy_https.txt
src/cmd/go/testdata/script/mod_pseudo_cache.txt
src/cmd/go/testdata/script/mod_replace_gopkgin.txt
src/cmd/go/testdata/script/mod_retract_pseudo_base.txt
src/cmd/go/testdata/script/mod_sumdb_file_path.txt
src/cmd/go/testdata/script/mod_sumdb_golang.txt
src/cmd/go/testdata/script/mod_vcs_missing.txt
src/cmd/go/testdata/script/reuse_git.txt
src/cmd/go/testdata/script/vendor_list_issue11977.txt
src/cmd/go/testdata/script/vendor_test_issue11864.txt
src/cmd/go/testdata/script/vendor_test_issue14613.txt