]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: don't mark argument array as noalg
authorKeith Randall <keithr@alum.mit.edu>
Fri, 14 Jun 2019 02:11:25 +0000 (19:11 -0700)
committerKeith Randall <khr@golang.org>
Tue, 25 Jun 2019 21:30:39 +0000 (21:30 +0000)
commit343b7fa6261a5b0ceaafed535438249ffa5686de
tree2cf02ce735c5aadc59079fbdbfc762855140e486
parent8382ccb0bcc57b5d4240bb662bc1e68c5d921b4c
cmd/compile: don't mark argument array as noalg

It ends up making two similar types, [N]uint8 of both
alg and noalg varieties. Comparsions between the two then
don't come out equal when they should.
In particular, the type *[N]uint8 has an Elem pointer which
must point to one of the above two types; it can't point to both.
Thus allocating a *[N]uint8 and dereferencing it might be a
different type than a [N]uint8.

The fix is easy. Making a small test for this is really hard. It
requires that both a argless defer and the test be imported by a
common parent package. This is why a main binary doesn't see this
issue, but a test does (as Agniva noticed), because there's a wrapper
package that imports both the test and the defer.

Types like [N]uint8 don't really need to be marked noalg anyway,
as the generated code (if any) will be shared among all
vanilla memory types of the same size.

Fixes #32595

Change-Id: If7b77fa6ed56cd4495601c3f90170682d853b82f
Reviewed-on: https://go-review.googlesource.com/c/go/+/182357
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/compile/internal/gc/reflect.go
test/fixedbugs/issue32595.dir/a.go [new file with mode: 0644]
test/fixedbugs/issue32595.dir/b.go [new file with mode: 0644]
test/fixedbugs/issue32595.dir/main.go [new file with mode: 0644]
test/fixedbugs/issue32595.go [new file with mode: 0644]