]> Cypherpunks repositories - gostls13.git/commit
encoding: report correct line numbers in tests
authorMark Ryan <mark.d.ryan@intel.com>
Thu, 15 Jun 2017 10:22:48 +0000 (11:22 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 15 Jun 2017 16:11:28 +0000 (16:11 +0000)
commit34ab42111cc989a2951134ef12c0e71888d41270
treebb9259cf490d2c9424c53eebbd0906e1f881d9c4
parent023593d0a858e31d9cf67c6c08ad3f6a7a9e842a
encoding: report correct line numbers in tests

Some of the _test.go files in the encoding packages contain a private
function called testEqual that calls testing.Errorf if the arguments
passed to it are unequal.   The line numbers output by such calls to
Errorf identify the failure as being in testEqual itself which is not
very useful.  This commit fixes the problem by adding a call to the
new t.Helper method in each of the testEqual functions.  The line
numbers output when errors do occur now identify the real source of
the error.

Change-Id: I582d1934f40ef2b788116c3811074c67ea882021
Reviewed-on: https://go-review.googlesource.com/45871
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/encoding/ascii85/ascii85_test.go
src/encoding/base32/base32_test.go
src/encoding/base64/base64_test.go