]> Cypherpunks repositories - gostls13.git/commit
cmd/go: list directories in module cache replacements
authorJay Conrod <jayconrod@google.com>
Tue, 5 Mar 2019 19:53:03 +0000 (14:53 -0500)
committerJay Conrod <jayconrod@google.com>
Fri, 15 Mar 2019 21:45:04 +0000 (21:45 +0000)
commit356f5a117641711e8ef6df731dfeefefbe2fe3e3
treeeab83205465016bdff73268e6f09ba3275f328f6
parent37e4a61d26d3b10aa11c5155b72c6bc882bd3122
cmd/go: list directories in module cache replacements

"go list" has allowed listing directory paths to packages in the
module cache since CL 126715. This is sometimes necessary for tools
gathering package information about source files in imported packages.

With this change, we only allow directories in the module cache for
modules in the build list after replacements are applied. Previously,
we ignored replacements when expanding file system path patterns while
constructing the build list.

Fixes #29548

Change-Id: Ic7f89122c4656c8967c14545cb7117f98e89e721
Reviewed-on: https://go-review.googlesource.com/c/go/+/165381
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/internal/modload/load.go
src/cmd/go/testdata/script/mod_list_replace_dir.txt [new file with mode: 0644]