]> Cypherpunks repositories - gostls13.git/commit
cmd/go: don't print dynimport link error messages
authorIan Lance Taylor <iant@golang.org>
Thu, 26 Sep 2024 04:03:54 +0000 (21:03 -0700)
committerGopher Robot <gobot@golang.org>
Thu, 26 Sep 2024 20:34:56 +0000 (20:34 +0000)
commit35874308993d5dbb3a618254babb5c1fa85bd1e3
treea70dd5ef6bc25f926108c05c47eb778ec0d2529c
parent712d47ce15d01d31798d8a9fe677d587cf21c1d6
cmd/go: don't print dynimport link error messages

When using the -x or -n option, we were printing the external
linker error messages from producing the dynimport file.
This was confusing because those linker errors are unimportant and
ignored; only the linker exit status matters, and failure doesn't
drop the build.

Change cmd/go -x to not print the error messages, and to instead
print the linker command line with a notation of whether the
link succeeded or failed.

Fixes #68743

Change-Id: Ie3cc58d2d6a7d33d7baa6f1273b4fb5a7deee7e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/615916
Reviewed-by: Michael Matloob <matloob@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/go/internal/work/exec.go
src/cmd/go/testdata/script/cgo_undef.txt