]> Cypherpunks repositories - gostls13.git/commit
[dev.fuzz] internal/fuzz: add mutex to workerClient
authorJay Conrod <jayconrod@google.com>
Thu, 3 Dec 2020 18:05:14 +0000 (13:05 -0500)
committerFilippo Valsorda <filippo@golang.org>
Fri, 4 Dec 2020 18:17:29 +0000 (19:17 +0100)
commit35f3b7053addf842690162d4d4937c0fbf438c50
treed6a16d6969752d66b9917c3e85346a7dd7e87122
parentdb514c0caf5effb4396c9746e025c1ba2d717604
[dev.fuzz] internal/fuzz: add mutex to workerClient

This prevents workerClient.Close from closing fuzzIn while
workerClient.fuzz is writing to it concurrently. It also prevents
multiple callers from writing to fuzzIn concurrently, though there's
nothing that does that yet.

This should prevent most "broken pipe" errors, though they may still
be possible if worker.stop is called and it needs to kill the process
due to a timeout. In the future, we should detect and ignore those
errors, but for now, they're useful for debugging.

Also, improve documentation on workerClient and workerServer.

Change-Id: Ie2c870392d5e91674d3b1e32b2fa4f9de9ac3eb0
Reviewed-on: https://go-review.googlesource.com/c/go/+/275173
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Jay Conrod <jayconrod@google.com>
Reviewed-by: Katie Hockman <katie@golang.org>
src/internal/fuzz/worker.go