]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.13] net/http: avoid writing to Transport.ProxyConnectHeader
authorBryan C. Mills <bcmills@google.com>
Tue, 7 Jan 2020 17:03:28 +0000 (12:03 -0500)
committerBryan C. Mills <bcmills@google.com>
Tue, 7 Jan 2020 20:29:45 +0000 (20:29 +0000)
commit367da16e91af75888e44b02932d228af7c9b0244
tree297dfb823774c60a40b5eb122dd2a6dc2a10a41e
parentb570a4147dae9efd28b48cec5b0500f599a2a99e
[release-branch.go1.13] net/http: avoid writing to Transport.ProxyConnectHeader

Previously, we accidentally wrote the Proxy-Authorization header for
the initial CONNECT request to the shared ProxyConnectHeader map when
it was non-nil.

Updates #36431
Fixes #36434

Change-Id: I5cb414f391dddf8c23d85427eb6973f14c949025
Reviewed-on: https://go-review.googlesource.com/c/go/+/213638
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 249c85d3aab2ad2d0bcbf36efe606fdd66f25c72)
Reviewed-on: https://go-review.googlesource.com/c/go/+/213657
src/net/http/transport.go
src/net/http/transport_test.go