]> Cypherpunks repositories - gostls13.git/commit
runtime: add crash stack support for wasm
authorMauri de Souza Meneguzzo <mauri870@gmail.com>
Sun, 19 Nov 2023 20:21:22 +0000 (20:21 +0000)
committerCherry Mui <cherryyz@google.com>
Mon, 20 Nov 2023 21:26:51 +0000 (21:26 +0000)
commit369ce90d2c734f7a8d08547219d2f39fa521ff71
tree49fe39dc8fef7589184225aec6c142b05e78f8d4
parentddb38c3f540c17a0437132532f49f6f0061d82af
runtime: add crash stack support for wasm

Currently if morestack on g0 happens the wasm runtime prints
"RuntimeError: memory access out of bounds", which is quite misleading.
By switching to a crash stack we can get better stacktraces
for the error.

There is no way to automate tests for this feature on wasm, since
TestG0StackOverflow relies on spawning a subprocess which is not
supported by the wasm port.

The way I got this tested manually is to comment everything in
TestG0StackOverflow, leaving just runtime.G0StackOverflow().

Then it is a matter of invoking the test:

    GOOS=js GOARCH=wasm go test runtime -v -run=TestG0StackOverflow

Change-Id: If450f3ee5209bb32efc1abd0a34b1cc4a29d0c46
GitHub-Last-Rev: 0d7c396e4cfeadc1188cae2b55661af10c8189e7
GitHub-Pull-Request: golang/go#63956
Reviewed-on: https://go-review.googlesource.com/c/go/+/539995
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/asm.s
src/runtime/asm_wasm.s
src/runtime/proc.go