]> Cypherpunks repositories - gostls13.git/commit
cmd/go: skip some tests that run builds in short mode
authorMichael Matloob <matloob@golang.org>
Fri, 28 Feb 2025 21:57:44 +0000 (16:57 -0500)
committerMichael Matloob <matloob@golang.org>
Wed, 5 Mar 2025 18:23:35 +0000 (10:23 -0800)
commit37026a7c563c580bef0fac1e5b60e9498650e3a2
tree5a99be91e4609897716400e0de7ce8cd9291260a
parent932a4a4befc804fc5f94c12e1e430442557875fe
cmd/go: skip some tests that run builds in short mode

cmd/go tests that run builds are generally skipped in short mode. This
change will adds skips for some tests that were running builds.

I found these by sorting tests by elapsed time and removing the top
tests that invoked go build. It's our practice to skip tests that run go
build without the -n flag (which prints but doesn't execute commands).

On my work laptop this reduces test run time from about 20 seconds to
about 16 seconds. On my linux workstation it reduces test run time from
about 10 seconds to about 5 seconds.

Change-Id: I18ffcc231df013cb6ac5f5eb3544bed28dadeda8
Reviewed-on: https://go-review.googlesource.com/c/go/+/653775
Reviewed-by: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/go/go_test.go
src/cmd/go/note_test.go
src/cmd/go/testdata/script/build_GOTMPDIR.txt
src/cmd/go/testdata/script/cgo_path.txt
src/cmd/go/testdata/script/clean_cache_n.txt
src/cmd/go/testdata/script/goauth_userauth.txt
src/cmd/go/testdata/script/test_skip.txt
src/cmd/go/testdata/script/vet_flags.txt
src/cmd/go/testdata/script/work.txt