]> Cypherpunks repositories - gostls13.git/commit
runtime: revert "traceback: include pc=0x%x for inline frames"
authorRuss Cox <rsc@golang.org>
Thu, 14 Mar 2024 19:30:13 +0000 (15:30 -0400)
committerGopher Robot <gobot@golang.org>
Thu, 14 Mar 2024 20:20:55 +0000 (20:20 +0000)
commit386dcf4c93bfc8af232a12086d73da4bb3558af9
treeec3b78531f10f9f51d248ed0547265b0bb649b6f
parent966609ad9e82ba173bcc8f57f4bfc35a86a62c8a
runtime: revert "traceback: include pc=0x%x for inline frames"

This reverts commit 643d816c8b43 (CL 561635).

Reason for revert: This works for telemetry but broke various other
properties of the tracebacks as well as some programs that read
tracebacks. We should figure out a solution that works for all uses,
and in the interim we should not be making telemetry work at the
cost of breaking other, existing valid uses.

See #65761 for details.

Change-Id: I467993ae778887e5bd3cca4c0fb54e9d44802ee1
Reviewed-on: https://go-review.googlesource.com/c/go/+/571797
Auto-Submit: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/crash_test.go
src/runtime/traceback.go
src/runtime/traceback_system_test.go [deleted file]