]> Cypherpunks repositories - gostls13.git/commit
syscall: fix skipping TestUseCgroupFD
authorKir Kolyshkin <kolyshkin@gmail.com>
Thu, 17 Aug 2023 00:45:14 +0000 (17:45 -0700)
committerGopher Robot <gobot@golang.org>
Fri, 1 Sep 2023 04:33:32 +0000 (04:33 +0000)
commit38b623f42da899ba7fd6b3fd791a7a72ebd5fad0
tree6af67c42dbcb20fef250f2f158553997ac100399
parent62fb281cf72d4b7fa0a29500911a4af3a244f90f
syscall: fix skipping TestUseCgroupFD

The check in prepareCgroupFD tried to find out if clone3 with
CLONE_INTO_CGROUP flag is supported, by supplying arguments in
SysProcAttr that will make ForkExec use clone3 with CLONE_INTO_CGROUP
and fail.

CL 456375 inadvertently broke the above check by adding more errno
values to ignore. As a result, TestUseCgroupFD is always skipped, even
when the test could in fact be run.

Fix by removing the check entirely, instead let's use the functionality
and figure out from the errno if this has failed because of unsupported
syscall, lack of permissions, or other reason.

Change-Id: I108b27b6cfeec390ebd3f161ac39e8597569b666
Reviewed-on: https://go-review.googlesource.com/c/go/+/520265
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Kirill Kolyshkin <kolyshkin@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
src/syscall/exec_linux_test.go