]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: bug fixes for DWARF location lists
authorHeschi Kreinick <heschi@google.com>
Fri, 25 Aug 2017 16:27:15 +0000 (12:27 -0400)
committerHeschi Kreinick <heschi@google.com>
Fri, 25 Aug 2017 20:37:32 +0000 (20:37 +0000)
commit38bd725bf1d20c32487ae7e12e37c0060a46ac0f
tree8845f7034fafb9e39a923683c78922615cb04bbb
parentdc42ffff594b12455b4e419bdae4cb707f602f4a
cmd/compile: bug fixes for DWARF location lists

Fix two small but serious bugs in the DWARF location list code that
should have been caught by the automated tests I didn't write.

After emitting debug information for a user variable, mark it as done
so that it doesn't get emitted again. Otherwise it would be written once
per slot it was decomposed into.

Correct a merge error in CL 44350: the location list abbreviations need
to have DW_AT_decl_line too, otherwise the resulting DWARF is gibberish.

Change-Id: I6ab4b8b32b7870981dac80eadf0ebfc4015ccb01
Reviewed-on: https://go-review.googlesource.com/59070
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/gc/pgen.go
src/cmd/internal/dwarf/dwarf.go