]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: remove broken rules
authorKeith Randall <khr@google.com>
Mon, 2 Jul 2018 16:43:37 +0000 (09:43 -0700)
committerKeith Randall <khr@golang.org>
Mon, 2 Jul 2018 20:00:38 +0000 (20:00 +0000)
commit398a8ed653929f9901ec14c1fa3d048955050f44
treefa5b0167a092ea6fb219cf5a99688b309780a311
parentadfa8b86915296d1e98ce695420fc6d1faba6eb6
cmd/compile: remove broken rules

These rules don't even type check.  ADDQconstmodify returns memory,
and it is being rewritten to a value that returns an int64.

There should be a MOVQstore wrapped around the result.
These rules never fire during all.bash, so they aren't even tested.

I'm just going to remove them for now.

Change-Id: I76008eb51ae4e16c707fac73c05a8d67cac149ae
Reviewed-on: https://go-review.googlesource.com/121935
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/compile/internal/ssa/gen/AMD64.rules
src/cmd/compile/internal/ssa/rewriteAMD64.go