]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: stop MOVW-ing -1 as SRA shift amount in mips
authorAlberto Donizetti <alb.donizetti@gmail.com>
Tue, 17 Nov 2020 09:13:29 +0000 (10:13 +0100)
committerAlberto Donizetti <alb.donizetti@gmail.com>
Wed, 18 Nov 2020 12:04:06 +0000 (12:04 +0000)
commit399b5d14d4114b326096127df9a89342eb1fc2ad
tree5c740475fbd5d90ffc2f99b2a73e1e71e5bf7641
parenta14e7bf6d42d9a8b0d698c0a47422c12e38b3f6c
cmd/compile: stop MOVW-ing -1 as SRA shift amount in mips

The shift amount in SRAconst needs to be in the [0,31] range, so stop
MOVWing -1 to SRA in the Rsh lowering rules.

Also see CL 270117.

Passes

  $ GOARCH=mips go build -toolexec 'toolstash -cmp' -a std
  $ GOARCH=mipsle go build -toolexec 'toolstash -cmp' -a std

Updates #42587

Change-Id: Ib5eb99b82310e404cc2d6f0c619b21b8a15406ce
Reviewed-on: https://go-review.googlesource.com/c/go/+/270558
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/ssa/gen/MIPS.rules
src/cmd/compile/internal/ssa/rewriteMIPS.go