]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: fix TestCPUProfileWithFork for GOOS=android.
authorHyang-Ah Hana Kim <hyangah@gmail.com>
Fri, 27 Mar 2015 00:02:50 +0000 (20:02 -0400)
committerHyang-Ah Hana Kim <hyangah@gmail.com>
Fri, 27 Mar 2015 18:07:06 +0000 (18:07 +0000)
commit39bc78845bba57db02a88b52a47fcd8dba109c3d
tree9dfbccb1a7647d518987197d5f5bc821c0013b25
parentdde5b56c91e9fc40a61f2f84684c2f7a8f3088c6
runtime/pprof: fix TestCPUProfileWithFork for GOOS=android.

1) Large allocation in this test caused crash. This was not
detected by builder because builder runs tests with -test.short.

2) The command "go" for forking doesn't exist in some platforms
including android. This change uses the test binary itself which
is guaranteed to exist.

This change also adds logging of the total samples collected in
TestCPUProfileMultithreaded test that is flaky in android-arm
builder.

Change-Id: I225c6b7877d811edef8b25e7eb00559450640c42
Reviewed-on: https://go-review.googlesource.com/8131
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/runtime/pprof/pprof_test.go