]> Cypherpunks repositories - gostls13.git/commit
crypto/x509: always emit a critical SAN extension if the Subject is empty.
authorAdam Langley <agl@golang.org>
Fri, 13 Oct 2017 22:36:01 +0000 (15:36 -0700)
committerAdam Langley <agl@golang.org>
Fri, 17 Nov 2017 19:00:41 +0000 (19:00 +0000)
commit3a395e22832774ff56d6b82cb8d91bc31167bd8e
tree7e82b762f3d8541fd8f3b944d298d7b799c9c6b5
parent2f1de1593e7993b233aa90ce874c407ae03741f8
crypto/x509: always emit a critical SAN extension if the Subject is empty.

The RFC is a little ambiguous here: “the subject field contains an empty
sequence” could mean that it's a non-empty sequence where one of the
sets contains an empty sequence. But, in context, I think it means “the
subject field is an empty sequence”.

Fixes #22249

Change-Id: Idfe1592411573f6e871b5fb997e7d545597a0937
Reviewed-on: https://go-review.googlesource.com/70852
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/crypto/x509/x509.go
src/crypto/x509/x509_test.go