]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: enable signature algorithm BoGo tests (and fix two bugs)
authorFilippo Valsorda <filippo@golang.org>
Fri, 23 May 2025 16:04:36 +0000 (18:04 +0200)
committerGopher Robot <gobot@golang.org>
Tue, 27 May 2025 15:37:16 +0000 (08:37 -0700)
commit3a3c006ac07886aa923a8aad0a4b3ed954640973
treeb2a15c4103ad86421e40c39f76fe9a9260dcc4be
parented70477909c97f86f8d73bee2d8680b6788acec7
crypto/tls: enable signature algorithm BoGo tests (and fix two bugs)

The two bugs are very minor:

- We were trying to set the ConnectionState CurveID field even if the
  RSA key exchange was in use

- We were sending the wrong alert from TLS 1.2 clients if none of the
  certificate signature algorithms were supported

Change-Id: I6a6a46564f5a9f1a5d44e54fc59a650118ad67d5
Reviewed-on: https://go-review.googlesource.com/c/go/+/675918
Auto-Submit: Filippo Valsorda <filippo@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
12 files changed:
src/crypto/tls/auth.go
src/crypto/tls/bogo_config.json
src/crypto/tls/bogo_shim_test.go
src/crypto/tls/common.go
src/crypto/tls/conn.go
src/crypto/tls/defaults.go
src/crypto/tls/fips140_test.go
src/crypto/tls/handshake_client.go
src/crypto/tls/handshake_client_tls13.go
src/crypto/tls/handshake_server.go
src/crypto/tls/handshake_server_tls13.go
src/crypto/tls/key_agreement.go