]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: change ir.InstExpr.Targs from Node to Ntype
authorMatthew Dempsky <mdempsky@google.com>
Tue, 3 May 2022 19:51:25 +0000 (12:51 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 5 May 2022 18:48:54 +0000 (18:48 +0000)
commit3abe8fe00bdc9ae35b54c36e5e73632346051315
tree46b93b7a1832c71eaa0061b8bac1eabf2d631abc
parent025a9c343880f9dc98c7c7479ab481a061e60950
cmd/compile: change ir.InstExpr.Targs from Node to Ntype

Type arguments are always type expressions, which are semantically
represented by Ntype.

In fact, the slice should probably just be []*types.Type instead, and
that would remove a lot of ir.TypeNode wrapping/unwrapping. But this
lead to issues within the stenciling code, and I can't immediately
make sense why.

Change-Id: Ib944db30e4d21284bc2d8d954b68ecb70b4205a9
Reviewed-on: https://go-review.googlesource.com/c/go/+/403843
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/ir/expr.go
src/cmd/compile/internal/ir/node_gen.go
src/cmd/compile/internal/noder/expr.go
src/cmd/compile/internal/noder/object.go
src/cmd/compile/internal/noder/stencil.go
src/cmd/compile/internal/typecheck/iimport.go
src/cmd/compile/internal/typecheck/subr.go