]> Cypherpunks repositories - gostls13.git/commit
runtime: rename getcallerfp to getfp
authorFelix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Mon, 3 Apr 2023 23:10:55 +0000 (01:10 +0200)
committerQuim Muntal <quimmuntal@gmail.com>
Mon, 22 May 2023 10:04:13 +0000 (10:04 +0000)
commit3afbca5c5ff91b1b577b77cde6aecbfaac5881e5
tree621cb0af9014ee68d13afad4642b311ca054dc42
parentd75cc4b9c6e2acb4d0ed3d90c9a8b38094af281b
runtime: rename getcallerfp to getfp

The previous name was wrong due to the mistaken assumption that calling
f->g->getcallerpc and f->g->getcallersp would respectively return the
pc/sp at g. However, they are actually referring to their caller's
caller, i.e. f.

Rename getcallerfp to getfp in order to stay consistent with this
naming convention.

Also see discussion on CL 463835.

For #16638

This is a redo of CL 481617 that became necessary because CL 461738
added another call site for getcallerfp().

Change-Id: If0b536e85a6c26061b65e7b5c2859fc31385d025
Reviewed-on: https://go-review.googlesource.com/c/go/+/494857
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
16 files changed:
src/runtime/asm_amd64.s
src/runtime/asm_arm64.s
src/runtime/export_test.go
src/runtime/export_windows_test.go
src/runtime/os_wasm.go
src/runtime/stubs_386.go
src/runtime/stubs_amd64.go
src/runtime/stubs_arm.go
src/runtime/stubs_arm64.go
src/runtime/stubs_loong64.go
src/runtime/stubs_mips64x.go
src/runtime/stubs_mipsx.go
src/runtime/stubs_ppc64x.go
src/runtime/stubs_riscv64.go
src/runtime/stubs_s390x.go
src/runtime/trace.go