]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.12] crypto/x509: fix value ownership in isSSLPolicy on macOS
authorFilippo Valsorda <filippo@golang.org>
Tue, 21 May 2019 18:54:54 +0000 (14:54 -0400)
committerDmitri Shuralyov <dmitshur@golang.org>
Fri, 7 Jun 2019 20:51:11 +0000 (20:51 +0000)
commit3b05c3c2e68296ebcb9efd9b4b0739161dac964f
tree37d6867e13b20d9113ab93900be39f59f9f4f85a
parentafcfe0d3c2980722af0dc55a3422c19cc53f5a65
[release-branch.go1.12] crypto/x509: fix value ownership in isSSLPolicy on macOS

CFDictionaryGetValueIfPresent does not take ownership of the value, so
releasing the properties dictionary before passing the value to CFEqual
can crash. Not really clear why this works most of the time.

See https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html

Fixes #32282
Updates #28092
Updates #30763

Change-Id: I5ee7ca276b753a48abc3aedfb78b8af68b448dd4
Reviewed-on: https://go-review.googlesource.com/c/go/+/178537
Reviewed-by: Adam Langley <agl@golang.org>
(cherry picked from commit a3d4655c2435e3777c45f09650539b943bab1c66)
Reviewed-on: https://go-review.googlesource.com/c/go/+/179339
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/crypto/x509/root_cgo_darwin.go