]> Cypherpunks repositories - gostls13.git/commit
crypto/sha512: Avo port of sha512block_amd64.s
authorGarrett Bodley <garrett.bodley@gmail.com>
Thu, 18 Jul 2024 00:00:53 +0000 (20:00 -0400)
committerRoland Shoemaker <roland@golang.org>
Wed, 4 Sep 2024 20:36:05 +0000 (20:36 +0000)
commit3b78ca06262988992ac3427a0acb4e1c7ac482ac
tree5c3dd61e17a1ed6c81fc99ae8d9665fc19024fe0
parentf9eb06c3022b20ae0b7944717d58d582eb5677ea
crypto/sha512: Avo port of sha512block_amd64.s

This implementation utilizes the same registers found in the reference
implementation, aiming to produce a minimal semantic diff between the
Avo-generated output and the original hand-written assembly.

To verify the Avo implementation, the reference and Avo-generated
assembly files are fed to `go tool asm`, capturing the debug output into
corresponding temp files. The debug output contains supplementary
metadata (line numbers, instruction offsets, and source file references)
that must be removed in order to obtain a semantic diff of the two
files. This is accomplished via a small utility script written in awk.

Commands used to verify Avo output:

GOROOT=$(go env GOROOT)
ASM_PATH="src/crypto/sha512/sha512block_amd64.s"
REFERENCE="54fe0fd43fcf8609666c16ae6d15ed92873b1564"

go tool asm -o /dev/null -I "$GOROOT"/src/runtime -debug \
  <(git cat-file -p "$REFERENCE:$ASM_PATH") \
  > /tmp/reference.s

go tool asm -o /dev/null -I "$GOROOT"/src/runtime -debug \
  "$ASM_PATH" \
  > /tmp/avo.s

normalize(){
  awk '{
    $1=$2=$3="";
    print substr($0,4)
  }'
}

diff <(normalize < /tmp/reference.s) <(normalize < /tmp/avo.s)

Change-Id: I172f0cb97252635c657efe82d1b547e6b6f40ebb
Reviewed-on: https://go-review.googlesource.com/c/go/+/598958
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/cmd/compile/internal/types2/stdlib_test.go
src/crypto/sha512/_asm/go.mod [new file with mode: 0644]
src/crypto/sha512/_asm/go.sum [new file with mode: 0644]
src/crypto/sha512/_asm/sha512block_amd64_asm.go [new file with mode: 0644]
src/crypto/sha512/sha512block_amd64.s
src/go/types/stdlib_test.go