]> Cypherpunks repositories - gostls13.git/commit
crypto/elliptic: fix incomplete addition used in CombinedMult on s390x
authorMichael Munday <mike.munday@ibm.com>
Mon, 18 Sep 2017 10:55:18 +0000 (11:55 +0100)
committerMichael Munday <mike.munday@ibm.com>
Thu, 5 Oct 2017 17:49:00 +0000 (17:49 +0000)
commit3b8a031569f5f209e97c6a815fcf24a2c4c05e65
tree47349bb3b3995536985594e133fbb1db095f20cd
parentd24a36cc4caf51c88082c9b17201b6088b9bfc86
crypto/elliptic: fix incomplete addition used in CombinedMult on s390x

This applies the amd64-specific changes from CL 42611 to the s390x P256
implementation. The s390x implementation was disabled in CL 62292 and
this CL re-enables it.

Adam Langley's commit message from CL 42611:

The optimised P-256 includes a CombinedMult function, which doesn't do
dual-scalar multiplication, but does avoid an affine conversion for
ECDSA verification.

However, it currently uses an assembly point addition function that
doesn't handle exceptional cases.

Fixes #20215.

Change-Id: I2f6b532f495e85b8903475b4f64cc32a3b2f6769
Reviewed-on: https://go-review.googlesource.com/64290
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/crypto/elliptic/p256_asm_s390x.s
src/crypto/elliptic/p256_s390x.go