]> Cypherpunks repositories - gostls13.git/commit
cmd/go: force -coverpkg main packages to be built as libraries
authorJay Conrod <jayconrod@google.com>
Fri, 10 May 2019 15:49:08 +0000 (11:49 -0400)
committerJay Conrod <jayconrod@google.com>
Fri, 10 May 2019 16:28:38 +0000 (16:28 +0000)
commit3b8c804164e26bdec6ca94a5ab1b5c35fa119e5e
tree01d27b1bfbcdc6b85c3efc5a238adcf86b266507
parentef4666eccedd457b33baa5b7d4bff95680e60741
cmd/go: force -coverpkg main packages to be built as libraries

This fixes TestScript/cover_pkgall_multiple_mains, which started
failing after CL 174657.

When compiling main packages with coverage instrumentation
(e.g., for -coverpkg all), we now pass -p with the full import path
instead of '-p main'. This avoids link errors
'duplicate symbol main.main (types 1 and 1)'.

Fixes #31946

Change-Id: Id147527b1dbdc14bb33ac133c30d50c250b4365c
Reviewed-on: https://go-review.googlesource.com/c/go/+/176558
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/go/internal/load/test.go