]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix failure to reset reused bit of storage
authorDavid Chase <drchase@google.com>
Fri, 9 Mar 2018 22:33:29 +0000 (17:33 -0500)
committerDavid Chase <drchase@google.com>
Tue, 13 Mar 2018 05:03:31 +0000 (05:03 +0000)
commit3c16934f1638d3d756fb315b847a3805ac06de88
treefc18c54920207d0e661d57a538bfc6a8ed0dfb4e
parent867d07f3ac708556f406f75e08bc68c70567f907
cmd/compile: fix failure to reset reused bit of storage

This is the "3rd bug" that caused compilations to sometimes
produce different results when dwarf location lists were
enabled.

A loop had not been properly rewritten in an earlier
optimization CL, and it accessed uninitialized data,
which was deterministically perhaps wrong when single
threaded, but variably wrong when multithreaded.

Change-Id: Ib3da538762fdf7d5e4407106f2434f3b14a1d7ea
Reviewed-on: https://go-review.googlesource.com/99935
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/cmd/compile/internal/ssa/debug.go