]> Cypherpunks repositories - gostls13.git/commit
go/doc: enable AllMethods flag (and fix logic)
authorRobert Griesemer <gri@golang.org>
Tue, 31 Jan 2012 17:48:10 +0000 (09:48 -0800)
committerRobert Griesemer <gri@golang.org>
Tue, 31 Jan 2012 17:48:10 +0000 (09:48 -0800)
commit3c6bebf5a7b4a5678460abf2e48f21bc369e0d3a
tree6f55140a59f4aaad498e0073388e72d5ddf802ac
parentc0ecfb072b02d5764e387af560bfedb1cadcac1c
go/doc: enable AllMethods flag (and fix logic)

- enable AllMethods flag (default: not set)
- fix logic determining which methods to show
- added respective test case in testdata/e.go for AllMethods = false
- added test case set for AllMethods = true

The critical changes/files to look at are:
- testdata/e{0,1,2}.golden: T4.M should only show up as method of T5 in e2.golden
- reader.go: always include top-level methods, and negate former logic for embedded methods
  (rewrote as a switch for better comprehensability)

Fixes #2791.

R=rsc, rsc
CC=golang-dev
https://golang.org/cl/5576057
14 files changed:
src/cmd/api/goapi.go
src/pkg/go/doc/doc.go
src/pkg/go/doc/doc_test.go
src/pkg/go/doc/exports.go
src/pkg/go/doc/reader.go
src/pkg/go/doc/testdata/a.2.golden [new file with mode: 0644]
src/pkg/go/doc/testdata/b.2.golden [new file with mode: 0644]
src/pkg/go/doc/testdata/c.2.golden [new file with mode: 0644]
src/pkg/go/doc/testdata/d.2.golden [new file with mode: 0644]
src/pkg/go/doc/testdata/e.0.golden
src/pkg/go/doc/testdata/e.1.golden
src/pkg/go/doc/testdata/e.2.golden [new file with mode: 0644]
src/pkg/go/doc/testdata/e.go
src/pkg/go/doc/testdata/testing.2.golden [new file with mode: 0644]