]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.8] cmd/link: make mach-o dwarf segment properly aligned
authorRuss Cox <rsc@golang.org>
Thu, 30 Mar 2017 00:53:32 +0000 (20:53 -0400)
committerAustin Clements <austin@google.com>
Wed, 5 Apr 2017 16:58:33 +0000 (16:58 +0000)
commit3ca0d34fa12abad8fc5ca8b8fabec0c1b2c0d288
tree5630c56db37c25aef9dbae61114ccd2e94dde8d3
parent84192f2734c276baa3f2814d465eadc8eda82ce5
[release-branch.go1.8] cmd/link: make mach-o dwarf segment properly aligned

Without this, the load fails during kernel exec, which results in the
mysterious and completely uninformative "Killed: 9" error.

It appears that the stars (or at least the inputs) were properly aligned
with earlier versions of Xcode so that this happened accidentally.
Make it happen on purpose.

Gregory Man bisected the breakage to this change in LLVM,
which fits the theory nicely:
https://github.com/llvm-mirror/llvm/commit/9a41e59c

Fixes #19734.

Change-Id: Ice67a09af2de29d3c0d5e3fcde6a769580897c95
Reviewed-on: https://go-review.googlesource.com/39603
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
misc/cgo/testcshared/test.bash
src/cmd/link/internal/ld/macho_combine_dwarf.go