]> Cypherpunks repositories - gostls13.git/commit
go/importer: disable TestForCompiler/LookupCustom for GOEXPERIMENT=unified
authorMatthew Dempsky <mdempsky@google.com>
Sat, 14 May 2022 00:00:00 +0000 (17:00 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Mon, 16 May 2022 09:31:42 +0000 (09:31 +0000)
commit3caf67d247c102edfb8347f010e44afa143f46b5
treeab1987812c1a12ed0eadf3cabfbf3305f5820b80
parent568590b0856d457f38404505f96d21032c35f844
go/importer: disable TestForCompiler/LookupCustom for GOEXPERIMENT=unified

The TestForCompiler/LookupCustom test tries to read in the export data
for "math/big", but with a package path of "math/bigger" instead. This
has historically worked because the export data formats were designed
to not assume the package's own path, but I expect we can safely
remove support for this now.

However, since that would be a user-visible change, for now just
disable the test for GOEXPERIMENT=unified so we can land CL 393715. We
can revisit whether it's actually safe to break that go/importer use
case later.

Updates #51734.

Change-Id: I5e89314511bd1352a9f5e14a2e218a5ab00cab3c
Reviewed-on: https://go-review.googlesource.com/c/go/+/406319
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/go/importer/importer_test.go