]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/types: simplify iterating all parameters
authorMatthew Dempsky <mdempsky@google.com>
Sun, 20 Aug 2023 22:07:00 +0000 (15:07 -0700)
committerGopher Robot <gobot@golang.org>
Tue, 22 Aug 2023 20:57:01 +0000 (20:57 +0000)
commit3d15bfaa3e05c321dbec48bbcc634a3759b0b18a
tree2278db73ff5b1499974c46acd0ac97db7e2760bf
parent4b9a70a3b7101d01c67f1c7f839ab4f1234fda2e
cmd/compile/internal/types: simplify iterating all parameters

The types.RecvsParamsResults, etc. helpers existed to make it "easier"
to iterate over all parameters, or recvs+params, or params+results;
but they end up still being quite clumsy to use due to the design goal
of not allocating temporary slices.

Now that recvs+params+results are stored in a single consecutive slice
anyway, we can just return different subslices and simplify the loops.

Change-Id: I84791b80dc099dfbfbbe6eddbc006135528c23b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/521375
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/compile/internal/dwarfgen/dwarf.go
src/cmd/compile/internal/escape/escape.go
src/cmd/compile/internal/noder/linker.go
src/cmd/compile/internal/noder/reader.go
src/cmd/compile/internal/types/identity.go
src/cmd/compile/internal/types/type.go