]> Cypherpunks repositories - gostls13.git/commit
[dev.inline] cmd/compile/internal/syntax: use syntax.Pos for all external positions
authorRobert Griesemer <gri@golang.org>
Fri, 2 Dec 2016 18:44:34 +0000 (10:44 -0800)
committerRobert Griesemer <gri@golang.org>
Fri, 9 Dec 2016 01:35:14 +0000 (01:35 +0000)
commit3d5df64b3fe16757c9f271c2421715ba6d79b02d
treead84555a06191dc2376814b59226daa271e62fd5
parent54ef0447fed1a59b95111b86a037c3443daf0b9b
[dev.inline] cmd/compile/internal/syntax: use syntax.Pos for all external positions

- use syntax.Pos in syntax.Error (rather than line, col)
- use syntax.Pos in syntax.PragmaHandler (rather than just line)
- update uses
- better documentation in various places

Also:
- make Pos methods use Pos receiver (rather than *Pos)

Reviewed in and cherry-picked from https://go-review.googlesource.com/#/c/33891/.
With minor adjustments to noder.go to make merge compile.

Change-Id: I5507cea6c2be46a7677087c1aeb69382d31033eb
Reviewed-on: https://go-review.googlesource.com/34236
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/fmt_test.go
src/cmd/compile/internal/gc/noder.go
src/cmd/compile/internal/syntax/nodes.go
src/cmd/compile/internal/syntax/parser.go
src/cmd/compile/internal/syntax/pos.go
src/cmd/compile/internal/syntax/scanner.go
src/cmd/compile/internal/syntax/source.go
src/cmd/compile/internal/syntax/syntax.go