]> Cypherpunks repositories - gostls13.git/commit
cmd/go: don't stamp build or vcs info for GOROOT binaries
authorJay Conrod <jayconrod@google.com>
Thu, 14 Oct 2021 23:47:47 +0000 (16:47 -0700)
committerBryan C. Mills <bcmills@google.com>
Fri, 15 Oct 2021 02:02:50 +0000 (02:02 +0000)
commit3da0ff8e3b05333c378efe17585609598692791e
tree0fc39154ebeaebe5da9127c7b8c4994eff626045
parent0c45ed05612bb315c949229f7b484b4b573af4b0
cmd/go: don't stamp build or vcs info for GOROOT binaries

Fixes a test failure in cmd/go TestScript/mod_outside.

make.bash (cmd/dist) builds everything with -gcflags=all= -ldflags=all=
by default. If those no-op flags aren't used, all GOROOT binaries
appear stale.

It's likely safe to omit those flags in cmd/dist if they're
empty. Checking out a new commit in GOROOT would always cause
staleness since the VCS info would change.

For #37475

Change-Id: Ic9aa0f3b7318e05fbb2f7d2c008ad07a4c61952f
Reviewed-on: https://go-review.googlesource.com/c/go/+/356014
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/internal/load/pkg.go