]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: in prove pass, check for unsat before adding local facts
authorKeith Randall <khr@golang.org>
Fri, 9 Aug 2024 20:11:03 +0000 (13:11 -0700)
committerGopher Robot <gobot@golang.org>
Fri, 9 Aug 2024 20:53:07 +0000 (20:53 +0000)
commit3de175f38348f82f6cc7bfb49c3609e72a5f8f41
tree1a666776d37f21d977bb96e6431bbd929cc3ac2c
parentf259e4c916bcde5221dca99ce7d77095a21b9801
cmd/compile: in prove pass, check for unsat before adding local facts

Local facts can get us to unsatisfiable because there is an
unconditional panic in the block. That shouldn't declare the whole
block as unreachable, because we do still need to enter it to get
that panic.

Fixes #68816

Change-Id: I9220edb46089690702d2eb61d112815c7ac91f16
Reviewed-on: https://go-review.googlesource.com/c/go/+/604118
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/prove.go
test/fixedbugs/issue68816.go [new file with mode: 0644]