]> Cypherpunks repositories - gostls13.git/commit
internal/testenv: reduce init-time work for MustHaveExec
authorBryan C. Mills <bcmills@google.com>
Fri, 5 May 2023 13:29:34 +0000 (09:29 -0400)
committerGopher Robot <gobot@golang.org>
Fri, 5 May 2023 23:33:02 +0000 (23:33 +0000)
commit3e35df5edbb02ecf8efd6dd6993aabd5053bfc66
tree0a4f1eb9d87738ecc34fd886e285603ad68519e7
parent05ca41d3efdd1fc676bf3ff10afa95f91607eb0a
internal/testenv: reduce init-time work for MustHaveExec

In CL 486275 I added a somewhat complex init function that sets up a
callback to probe for exec support. A lot of the complexity was simply
to avoid an unnecessary call to os.Environ during init.

In CL 491660, I made the os.Environ call unconditional on all
platforms anyway in order to make HasGoBuild more robust.

Since the init-function indirection no longer serves a useful purpose,
I would like to simplify it to a package-level function, avoiding the
complexity of changing package variables at init time.

Change-Id: Ie0041d52cbde06ff14540192c8fba869a851158e
Reviewed-on: https://go-review.googlesource.com/c/go/+/492977
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/internal/testenv/exec.go