]> Cypherpunks repositories - gostls13.git/commit
runtime: do not inherit labels on system goroutines
authorMichael Pratt <mpratt@google.com>
Tue, 7 Dec 2021 20:59:14 +0000 (15:59 -0500)
committerMichael Pratt <mpratt@google.com>
Wed, 19 Jan 2022 16:33:05 +0000 (16:33 +0000)
commit3e45eb3ce1f28ccb6e4150b6c2c09ca8568874e6
treef56b3a51594247c84f6c2dbcb0958c381bd9ae19
parentbec2cc370871b998a131f5f363dab4a14b5f2eb2
runtime: do not inherit labels on system goroutines

GC background mark worker goroutines are created when the first GC is
triggered (or next GC after GOMAXPROCS increases). Since the GC can be
triggered from a user goroutine, those workers will inherit any pprof
labels from the user goroutine.

That isn't meaningful, so avoid it by excluding system goroutines from
inheriting labels.

Fixes #50032

Change-Id: Ib425ae561a3466007ff5deec86b9c51829ab5507
Reviewed-on: https://go-review.googlesource.com/c/go/+/369983
Reviewed-by: Austin Clements <austin@google.com>
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/runtime/proc.go