]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: enable BoGo DisabledCurve-HelloRetryRequest-TLS13
authorDaniel McCarney <daniel@binaryparadox.net>
Fri, 16 May 2025 18:40:27 +0000 (14:40 -0400)
committerDaniel McCarney <daniel@binaryparadox.net>
Wed, 21 May 2025 19:58:52 +0000 (12:58 -0700)
commit3e468dfd5e6624465716fe5d34358ba58f1e9e7b
tree948bad33e7949bc26864619081a199f0110aa742
parentdeb9a7e4ad8552a5f366877e626c223dea0e9d9b
crypto/tls: enable BoGo DisabledCurve-HelloRetryRequest-TLS13

The crypto/tls package produces the expected error for this test case,
and so it can be enabled.

Looking at the history of the relevant code it appears the TLS 1.3
implementation has always had the correct behaviour for HRR changing to
an unsupported group after the initial hello.

I think this test was skipped initially because at the time of
initial BoGo config commit we hadn't implemented the -curves argument
for the test shim yet, and this test relies on it. We later added
support for that flag alongside X25519Kyber768Draft00 KX and I think we
missed the chance to enable the test then.

Updates #72006

Change-Id: I27a2cd231e4b8762b0d9e2dbd3d8ddd5b87fd5cf
Reviewed-on: https://go-review.googlesource.com/c/go/+/673756
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Bypass: Daniel McCarney <daniel@binaryparadox.net>
src/crypto/tls/bogo_config.json