]> Cypherpunks repositories - gostls13.git/commit
runtime: adjust program counters in race detector
authorDmitry Vyukov <dvyukov@google.com>
Sat, 14 Feb 2015 12:54:25 +0000 (15:54 +0300)
committerDmitry Vyukov <dvyukov@google.com>
Fri, 20 Feb 2015 18:04:16 +0000 (18:04 +0000)
commit3fc529eabe4f26939959dd3b98aae314271e0a08
tree8501a688c265bf38d7d5b41df1c3911608887519
parent89a091de2405d0b03c015a322ac27bc749aaca8a
runtime: adjust program counters in race detector

In most cases we pass return PC to race detector,
and race runtime subtracts one from them.
However, in manual instrumentation in runtime
we pass function start PC to race runtime.
Race runtime can't distinguish these cases
and so it does not subtract one from top PC.
This leads to bogus line numbers in some cases.
Make it consistent and always pass what looks
like a return PC, so that race runtime can
subtract one and still get PC in the same function.

Also delete two unused functions.

Update #8053

Change-Id: I4242dec5e055e460c9a8990eaca1d085ae240ed2
Reviewed-on: https://go-review.googlesource.com/4902
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/runtime/race.go
src/runtime/race1.go
src/runtime/race_amd64.s