]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: use testenv.Command in tests instead of exec.Command
authorBryan C. Mills <bcmills@google.com>
Fri, 30 Jun 2023 16:47:06 +0000 (12:47 -0400)
committerGopher Robot <gobot@golang.org>
Thu, 20 Jul 2023 19:30:53 +0000 (19:30 +0000)
commit3ffc8a25569ed107ebc1786bbd4f993dd6689601
treece050073592b2aaa5c9c1ec706afb9cc475ad1b8
parent7c1157f9544922e96945196b47b95664b1e39108
runtime/pprof: use testenv.Command in tests instead of exec.Command

If the test is about to time out, testenv.Command sends SIGQUIT to the
child process. The runtime's SIGQUIT goroutine dump should help us to
determine whether the hangs observed in TestCPUProfileWithFork are a
symptom of #60108 or a separate bug.

For #59995.
Updates #60108.

Change-Id: I26342ca262b2b0772795c8be142cfcad8d90db30
Reviewed-on: https://go-review.googlesource.com/c/go/+/507356
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
src/runtime/pprof/pprof_test.go