]> Cypherpunks repositories - gostls13.git/commit
os/user: fix race detector failure
authorqmuntal <quimmuntal@gmail.com>
Mon, 18 Nov 2024 08:31:59 +0000 (09:31 +0100)
committerQuim Muntal <quimmuntal@gmail.com>
Tue, 19 Nov 2024 16:52:49 +0000 (16:52 +0000)
commit405a0c4ae86fe2761118ee6d1d59e59daf9b50cd
tree68cc4189a0b68452642ffe0e70040ec880cf3261
parentafa98806389ed935264b67eb7e90507a334180f2
os/user: fix race detector failure

The race detector doesn't like that windows.GetSid* functions return
pointers to the SID structure. This change makes these functions return
values instead and mark them with nocheckptr.

Fixes #70378

Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-race
Change-Id: Iba39d75bb31679d25a5ee43b51e4abb0c435dbac
Reviewed-on: https://go-review.googlesource.com/c/go/+/628995
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/internal/syscall/windows/security_windows.go
src/internal/syscall/windows/zsyscall_windows.go
src/os/user/lookup_windows.go