]> Cypherpunks repositories - gostls13.git/commit
net/http: fix parallel tests using global DefaultTransport
authorBrad Fitzpatrick <bradfitz@golang.org>
Tue, 22 Nov 2016 02:07:52 +0000 (02:07 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 22 Nov 2016 10:26:06 +0000 (10:26 +0000)
commit409a667f35f66b2b5fa219ee93f1a3ddc6e07b03
treeabc061ed63847eae890a4ea893a87bcaac952bc6
parent75055de84ab7ad0f36b4c93e5c851ea55b297c95
net/http: fix parallel tests using global DefaultTransport

When I added t.Parallel to some tests earlier, I overlooked some using
the global "Get" func, which uses DefaultTransport.

The DefaultTransport can have its CloseIdleConnections called by other
parallel tests. Use a private Transport instead.

Fixes #18006

Change-Id: Ia4faca5bac235cfa95dcf2703c25f3627112a5e9
Reviewed-on: https://go-review.googlesource.com/33432
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/net/http/main_test.go
src/net/http/serve_test.go