]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16] cmd/link/internal: fix use of DynlinkingGo with ppc64le tramp...
authorLynn Boger <laboger@linux.vnet.ibm.com>
Thu, 29 Apr 2021 21:07:25 +0000 (16:07 -0500)
committerCarlos Amedee <carlos@golang.org>
Wed, 2 Jun 2021 18:44:27 +0000 (18:44 +0000)
commit40b97d69218c5f31cf444a5dd1883799f94d9ffa
tree9634131be7dc512c97a90319184af3453baef78d
parent1613be84815e34b2c803694ac073b2ae67f18168
[release-branch.go1.16] cmd/link/internal: fix use of DynlinkingGo with ppc64le trampolines

When creating programs with large text sections on ppc64le,
trampolines are needed for calls that are too far; however
they are not created if the code is generated such that the TOC
register r2 is initialized and maintained in the code because
then the external linker can create the trampolines. Previously
the function DynlinkingGo was used to determine this but in the
case where plugins are used, this could return true even though
r2 is not valid.

To fix this problem I've added a new function r2Valid which returns
true when the build options indicate that the r2 is
initialized and maintained. Because of the ways that
DynlinkingGo is used I wanted to maintain its previous
behavior.

Fixes #45927

Change-Id: I6d902eba6ad41757aa6474948b79acdbd479cb38
Reviewed-on: https://go-review.googlesource.com/c/go/+/315289
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 9ed736ac2a99aa2e7ef7d8bed3b01ca8b20a6f80)
Reviewed-on: https://go-review.googlesource.com/c/go/+/316750
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/cmd/link/internal/ppc64/asm.go