]> Cypherpunks repositories - gostls13.git/commit
cmd/dist: fix GOROOT permissions on failure
authorBryan C. Mills <bcmills@google.com>
Fri, 15 Nov 2019 17:26:09 +0000 (12:26 -0500)
committerBryan C. Mills <bcmills@google.com>
Fri, 15 Nov 2019 20:56:53 +0000 (20:56 +0000)
commit4160a71d4206e11d2122d1d9520c55a5b95c2085
treea8f2f3168c96d9a202cdd4c36fad0a21b73c445f
parent9af8794353d2c19621c0264f9a3f78d671fc86ef
cmd/dist: fix GOROOT permissions on failure

While running various tests for #28387, I keep ending up with an
unwritable GOROOT after a failure.

While the unwritable GOROOT is a fairly exotic condition (normally
only happens on builders), it's somewhat annoying when debugging, so
I'm switching all of the log.Fatal* call sites to use the existing
fatalf function, which supports general atexit-like cleanup.

Updates #28387

Change-Id: I473cda7eacd9ad82bdeab647766373126dc7390e
Reviewed-on: https://go-review.googlesource.com/c/go/+/207341
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/dist/test.go