]> Cypherpunks repositories - gostls13.git/commit
net/http: deflake TestRetryRequestsOnError
authorBrad Fitzpatrick <bradfitz@golang.org>
Mon, 23 Jul 2018 23:42:10 +0000 (23:42 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 24 Jul 2018 00:25:50 +0000 (00:25 +0000)
commit416676f4d9bb2e14bce4e396c2ce67d091264751
tree7454e4f4563e43f7d802af790f9cd3e6df142884
parent240ae7e304c3fe2c22cc903964e19783f9cd6bac
net/http: deflake TestRetryRequestsOnError

There's a 50ms threshold in net/http.Transport that this test
sometimes hitting on slower devices. That was unrelated to what this
test was trying to test. So instead just t.Skip on RoundTrip errors
unless the failure was quick (under 25ms), in which case the error
must've been about something else. Our fast machines should catch
regressions there.

Fixes #25366

Change-Id: Ibe8e2716a5b68558b57d0b8b5c46f38e46a2cba2
Reviewed-on: https://go-review.googlesource.com/125555
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/net/http/export_test.go
src/net/http/transport.go
src/net/http/transport_test.go