]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.13] cmd/link: ensure cgo cflags do not leak into tvOS test
authorCarlos Amedee <carlos@golang.org>
Wed, 22 Jan 2020 20:30:52 +0000 (15:30 -0500)
committerCarlos Amedee <carlos@golang.org>
Wed, 26 Feb 2020 17:04:05 +0000 (17:04 +0000)
commit4169b1ea15139d00736cb616f122fef04adb2512
treecd4da8dc31e68522f96598f1d981c5f22fb918b3
parent6f57b10549a4ee145d643714211c8f36590853de
[release-branch.go1.13] cmd/link: ensure cgo cflags do not leak into tvOS test

Running the 'TestBuildForTvOS' test with CGO_CFLAGS set
with certain values would cause the test to fail. all.bash
would fail when CGO_CFLAGS was set to '-mmacosx-version-min=10.10'
because the --macosx-version-min flag is incompatible with tvOS.
The change guards against using an unintended flag in the unit test.

Updates #36846
Updated #35459

Change-Id: Ifc43f3ebfb23d37aabeaac2ea9efae5b877991bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/215957
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit ace25f82df0a27eb26a518e1883eb56c1bec6c5e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/218598
src/cmd/link/link_test.go