]> Cypherpunks repositories - gostls13.git/commit
syscall: make func Syscall use pointer maps from Go prototypes
authorRuss Cox <rsc@golang.org>
Fri, 12 Sep 2014 04:23:03 +0000 (00:23 -0400)
committerRuss Cox <rsc@golang.org>
Fri, 12 Sep 2014 04:23:03 +0000 (00:23 -0400)
commit4179439de8166ded9bf097c216e6596ead2ee433
tree12652f4ed874af5983373e1605bdddb14ddb27f5
parent99f7df0598238b03d78cc6c89e0bd6b6b9feb246
syscall: make func Syscall use pointer maps from Go prototypes

Before, Syscall and friends were having their arguments
treated conservatively. Now they will use the Go prototype,
which will mean the arguments are not considered pointers
at all.

This is safe because of CL 139360044.

The fact that all these non-Solaris systems were using
conservative scanning of the Syscall arguments is why
the failure that prompted CL 139360044 was only
observed on Solaris, which does something completely different.
If we'd done this earlier, we'd have seen the Solaris
failure in more places.

LGTM=khr
R=khr
CC=golang-codereviews
https://golang.org/cl/144730043
20 files changed:
src/syscall/asm_darwin_386.s
src/syscall/asm_darwin_amd64.s
src/syscall/asm_dragonfly_386.s
src/syscall/asm_dragonfly_amd64.s
src/syscall/asm_freebsd_386.s
src/syscall/asm_freebsd_amd64.s
src/syscall/asm_freebsd_arm.s
src/syscall/asm_linux_386.s
src/syscall/asm_linux_amd64.s
src/syscall/asm_linux_arm.s
src/syscall/asm_nacl_386.s
src/syscall/asm_nacl_amd64p32.s
src/syscall/asm_nacl_arm.s
src/syscall/asm_netbsd_386.s
src/syscall/asm_netbsd_amd64.s
src/syscall/asm_netbsd_arm.s
src/syscall/asm_openbsd_386.s
src/syscall/asm_openbsd_amd64.s
src/syscall/asm_plan9_386.s
src/syscall/asm_plan9_amd64.s