]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: ignore runtime-internal samples in test
authorRhys Hiltner <rhys.hiltner@gmail.com>
Wed, 22 May 2024 16:57:14 +0000 (09:57 -0700)
committerGopher Robot <gobot@golang.org>
Wed, 22 May 2024 18:14:50 +0000 (18:14 +0000)
commit41884dcd05546ced3634496d931d0b005fc8c2e6
treec29063f98442545507737787e34fe1a52cba66e8
parent3989bc8a80970c6790cf6d161984e870bdb952e4
runtime/pprof: ignore runtime-internal samples in test

Tests of the mutex profile focus on sync.Mutex, which is easy to
control. But since those tests still use the runtime, and contention on
internal runtime.mutex values is now also part of the mutex profile, we
have to filter out those samples before examining the profile. Otherwise
the test may be confused by stray contention on sched.lock (or other
runtime-internal locks) as a natural consequence of using goroutines.

Fixes #67563

Change-Id: I066a24674d8b719dbeca4a5c0f76b53bc07498c1
Reviewed-on: https://go-review.googlesource.com/c/go/+/586957
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/runtime/pprof/pprof_test.go